Repository navigation
Fix metrics errors - #3444
Merged
Merged
Fix metrics errors#3444
Conversation
There are cases where another logic path fails and the directory has not yet been created. This logic defensively ensures that will not happen. Bug: 576310224
Trying to be strict about requiring the value continues to craete metrics failures in new environments due to the non-local nature of the unique `user_id` file. That is causing no metrics to be transmitted at all, which is strictly a worse case. We can look for blocks of data where the field is not populated and try to resolve those issues after deployment, but we want to get most of the data. Bug: 576310224
See previous commit for reasoning. Too many possible failures to be so strict. Bug: 576310224
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
ser-io
approved these changes
Oct 27, 2026
No need to expose the lookup mechanism or environment variable strings.
cjreynol
force-pushed
the
fix_metrics_errors
branch
from
October 27, 2026 23:43
79a828b to
0b042c7
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 576310224