Skip to content

Fix missing attributions to come into compliance with the Apache license - #76

Open
acockrell wants to merge 2 commits into
google:mainfrom
acockrell:fix/mobile-use_attributions
Open

acockrell wants to merge 2 commits into
google:mainfrom
acockrell:fix/mobile-use_attributions

Conversation

@acockrell

Copy link
Copy Markdown

You've copied some work from Minitap's mobile-use yet you've explicitly dropped the attributions required by the Apache license.

This PR fixes that for you.

More context.

@google-cla

google-cla Bot commented Sep 12, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@KorvinSzanto

Copy link
Copy Markdown

Better sign the contributor license agreement, you wouldn't want any confusion about code ownership!

Google loves it when you grant them copyright but apparently couldn't care less about anyone else's copyright.

@acockrell

Copy link
Copy Markdown
Author

Better sign the contributor license agreement, you wouldn't want any confusion about code ownership!

I've already signed the CLA and re-run the check.

@mkitti

mkitti commented Sep 15, 2026

Copy link
Copy Markdown

This pull request importantly adds a NOTICE file which is an explicit requirement of the Apache License 2.0.

371aa6d on the main branch added some attribution but it does not add a NOTICE file with the prior content as per Section 4d of the Apache License 2.0:

If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License.

@racedale

Copy link
Copy Markdown

@somew1nd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants