fix(dotprompt-go): paginate directory store listings - #628
Open
rksharma-owg wants to merge 1 commit into
Open
rksharma-owg wants to merge 1 commit into
rksharma-owg wants to merge 1 commit into
Conversation
Honor cursors for sorted prompt and partial listings, return terminal pages correctly, and cover pagination boundaries with regression tests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go
DirStore.ListandListPartialsignore the returned cursor and repeat the first page. Honor cursor offsets after the existing filtering and sorting, return an empty cursor on the final page, and reject invalid cursors.Add filesystem regression tests for prompts and partials covering page progression, variants, nested names, terminal pages, invalid cursors, and limit boundaries. Document cursor usage and the absence of snapshot guarantees when files change between calls.
Fixes #500.
Validation
Tested commit:
a83a2163369b37b1bcc293a5b433f761378e75d0; baseline:964b3a83c49a357d4a1b215bd307d513f2a38aef.Patch/baseline preflight · Toolchain diagnostics
Existing CI failures
Preflight is not fully green. These failures also occur on unchanged baseline:
golang.org/x/text0.36.0 dependency.govulncheck: x/vuln 1.8.0 requires Go 1.26.Dependency and CI configuration changes are excluded from this focused pagination fix.