fix temperature flag so it takes effect - #981
Merged
copybara-service[bot] merged 3 commits intoAug 21, 2026
Merged
Conversation
RaviTriv
force-pushed
the
fix-softmax-temperature
branch
from
August 16, 2026 17:02
47d498d to
ff1572b
Compare
RaviTriv
marked this pull request as ready for review
August 18, 2026 01:35
RaviTriv
changed the title
jan-wassenberg
requested changes
Aug 21, 2026
jan-wassenberg
left a comment
jan-wassenberg
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing. We generally run with deterministic mode because our sampler is very basic, but good to fix this. One nit:
| const SMOptions& sm_options = {}) { | ||
| GCPP_ZONE(ctx, worker, Zones::kOpsSoftmax); | ||
| HWY_DASSERT(logits.size() != 0); | ||
| HWY_ASSERT(temperature >= 0.0f); |
Member
There was a problem hiding this comment.
This runs quite often, so prefer HWY_DASSERT.
jan-wassenberg
approved these changes
Aug 21, 2026
jan-wassenberg
added
the
copybara-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the temperature flag is not taking effect since its applied to the exponentiated logits and cancels against the normalization. Updating to divide the logits by temperature before exp so it affects the output.
Current
Temperature 0
Temperature 2
Updated
Temperature 0
Temperature 2
