Repository navigation
Conversation
tamird
force-pushed
the
license-text-classifier-final
branch
from
October 3, 2026 00:04
b77c42e to
c5e943b
Compare
Contributor
Author
|
Rebased onto current master, @EtiennePerot. Posted by Codex on behalf of @tamird. |
EtiennePerot
requested changes
Oct 3, 2026
EtiennePerot
left a comment
EtiennePerot
left a comment
Collaborator
There was a problem hiding this comment.
Hold on this for a week, it will fail internal checks until some exception goes through.
tamird
force-pushed
the
license-text-classifier-final
branch
2 times, most recently
from
October 13, 2026 14:34
44d3ce3 to
a2cedf2
Compare
tamird
force-pushed
the
license-text-classifier-final
branch
from
October 18, 2026 00:09
a2cedf2 to
b4e336c
Compare
Contributor
Author
|
@EtiennePerot, have the internal exceptions for this PR and #15145 propagated, or should both holds remain? Posted by Codex on behalf of @tamird. |
tamird
added a commit
to tamird/gvisor
that referenced
this pull request
Oct 18, 2026
Pair the regular source/provider sweep with the authorized follow-up on google#15146, covering both outstanding internal exceptions. Refresh google#15145 to its current head while preserving both maintainer holds. Assisted-by: Codex
tamird
force-pushed
the
license-text-classifier-final
branch
4 times, most recently
from
October 22, 2026 00:20
f7f7cd7 to
04108da
Compare
Replace phrase-based classification with complete license-text matching to avoid combining independent notices. The old matcher combined Arrow's BSD terms and OpenSSL's advertising clause into BSD-4-Clause [1]. Delegate text matching and identifier ownership to google/licensecheck [2], configured with the complete LLVM exception [3]. References alone do not establish a license grant. Keep the scanner's identifiers literal so policy review sees the distinctions the detector can establish. Regenerate the catalog for the new classifier dependency and the legacy University of Illinois/NCSA grants in LLVM [3] and Kythe [4], previously reported as MIT. Scope the corresponding policy exceptions to these two dependencies and record their redistribution conditions, retaining the existing source versions and archive hashes. [1]: https://github.com/apache/arrow/blob/e03105efc/go/LICENSE.txt [2]: https://github.com/google/licensecheck/blob/16aaea366/scan.go [3]: https://github.com/llvm/llvm-project/blob/cb2f0d0a5/LICENSE.TXT [4]: https://github.com/kythe/kythe/blob/a182743b6/LICENSE#L205-L251
tamird
force-pushed
the
license-text-classifier-final
branch
from
October 22, 2026 13:31
04108da to
bec0658
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace phrase-based classification with complete license-text matching
to avoid combining independent notices. The old matcher combined Arrow's
BSD terms and OpenSSL's advertising clause into BSD-4-Clause 1.
Delegate text matching and identifier ownership to google/licensecheck
2, configured with the complete LLVM exception 3. References alone
do not establish a license grant. Keep the scanner's identifiers literal
so policy review sees the distinctions the detector can establish.
Regenerate the catalog for the new classifier dependency and the legacy
University of Illinois/NCSA grants in LLVM 3 and Kythe 4, previously
reported as MIT. Scope the corresponding policy exceptions to these two
dependencies and record their redistribution conditions, retaining the
existing source versions and archive hashes.
Assisted-by: Codex