Repository navigation
[transports] Fix ioctl pointer argument in spi_nor_busy_wait - #325
Merged
Merged
Conversation
xorptr
self-requested a review
November 6, 2026 09:54
xorptr
reviewed
Nov 6, 2026
xorptr
previously approved these changes
Nov 6, 2026
Pass `&xfer` rather than `xfer` by value to `ioctl(fd, SPI_IOC_MESSAGE(1), ...)` when polling the SPI NOR status register WIP bit.
mfield4
force-pushed
the
spi-nor-busy-wait
branch
from
November 6, 2026 20:21
022302f to
4c06f26
Compare
mfield4
marked this pull request as ready for review
November 6, 2026 20:21
xorptr
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
&xferrather thanxferby value toioctl(fd, SPI_IOC_MESSAGE(1), ...)when polling the SPI NOR status register WIP bit.