Repository navigation
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
reyammer
force-pushed
the
py-debug-prerelease-fail
branch
5 times, most recently
from
January 9, 2026 17:32
503d4f5 to
8dd75fa
Compare
reyammer
changed the title
Add the --run-magika-via-uv option so that we can control when (and when not) it is appropriate to run magika via `uv run ...`.
reyammer
force-pushed
the
py-debug-prerelease-fail
branch
from
January 9, 2026 17:49
8dd75fa to
3f30ee6
Compare
reyammer
marked this pull request as ready for review
January 9, 2026 17:54
reyammer
force-pushed
the
py-debug-prerelease-fail
branch
from
January 9, 2026 18:24
59c890c to
f164d7d
Compare
reyammer
marked this pull request as draft
January 9, 2026 18:24
reyammer
force-pushed
the
py-debug-prerelease-fail
branch
from
January 9, 2026 18:41
3a61b26 to
d0c5178
Compare
invernizzi
approved these changes
Jan 9, 2026
Collaborator
Author
|
This PR is now not needed anymore. We tracked down the problem: the regression is due to a new version of maturin (from Jan 5th), which is actually the only dependency that we did not have pinned. Pinned maturin in #1264 as a workaround, we will check with the maturin folks to see whether it's a bug or we are doing something wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github released new runners 3 days ago (https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20260105.202), and since then the pre-release check script started failing. (There is a change the timing is just an unlucky coincidence.)
Root cause and fix: we try to get the rust's magika CLI version via
magika -V, but now this errors out with "magika not found". Since we install magika viauv, this is actually expected, and it's not clear how it worked in the past. Now doinguv run magika -Vinstead.Note also that we cannot always run magika with
uv run magika: this seems to break the pre-release script when running it after installing magika via pip on Windows. For this reason, we actually add a new CLI option--run-magika-via-uvto control how we try to run the magika client.