Repository navigation
Fix miscellaneous minor bugs in android_device_lib and test_runner - #1046
Open
xpconanfan wants to merge 2 commits into
Open
xpconanfan wants to merge 2 commits into
xpconanfan wants to merge 2 commits into
Conversation
xpconanfan
changed the title
xpconanfan
force-pushed
the
android-device-fixes
branch
from
October 6, 2026 07:47
56804b7 to
2afbcf8
Compare
* `SnippetClientV2._read_protocol_line`: remove the duplicate `self._server_start_stdout = []` reset that wiped output collected by the first protocol-line read.
* `AdbProxy.connect`: pass `stderr=b''` (bytes) to `AdbError` so callers like `root()` that call `e.stderr.decode()` don't fail with `AttributeError`.
* `SnippetManagementService`: pass `self._device` (not `self`) to `Error` (a `DeviceError` subclass), and drop the unused `self._is_alive` attribute.
* `ServiceManager.list_live_services`: use a list comprehension instead of `for_each` so a pure query doesn't go through `expect_no_raises`.
* `JsonRpcShellBase`: raise `Error` instead of `assert` (which is stripped under `python -O`).
* `TestRunner.get_full_test_names`: fix broken error formatting (`Error('... %s ...', (...))` passed a 2-arg tuple to `Exception` instead of formatting the string).
xpconanfan
force-pushed
the
android-device-fixes
branch
from
October 6, 2026 08:06
2afbcf8 to
cc34498
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnippetClientV2._read_protocol_line: remove the duplicateself._server_start_stdout = []reset that wiped output collected by the first protocol-line read.AdbProxy.connect: passstderr=b''(bytes) toAdbErrorso callers likeroot()that calle.stderr.decode()don't fail withAttributeError.SnippetManagementService: passself._device(notself) toError(aDeviceErrorsubclass), and drop the unusedself._is_aliveattribute.ServiceManager.list_live_services: use a list comprehension instead offor_eachso a pure query doesn't go throughexpect_no_raises.JsonRpcShellBase: raiseErrorinstead ofassert(which is stripped underpython -O).TestRunner.get_full_test_names: fix broken error formatting (Error('... %s ...', (...))passed a 2-arg tuple toExceptioninstead of formatting the string).