Repository navigation
Keep boot_completion_timeout only on handle_reboot() with default None - #1070
Closed
xpconanfan wants to merge 1 commit into
Closed
xpconanfan wants to merge 1 commit into
xpconanfan wants to merge 1 commit into
Conversation
Restore AndroidDevice.reboot(self) signature so subclasses overriding reboot(self) do not fail type checking, and default boot_completion_timeout to None on handle_reboot() so subclass wait_for_boot_completion() defaults are preserved when not explicitly specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1065:
AndroidDevice.reboot(self)withoutboot_completion_timeoutso subclasses overridingreboot(self)do not failbad-overridetype checking.handle_reboot(self, boot_completion_timeout=None)to default toNoneand only passtimeout=towait_for_boot_completion()when explicitly set, preserving subclasswait_for_boot_completion()defaults.