Repository navigation
Support rs::Movable<rs_std::Result<T, E>> in elf_bridge.cc's MapResult - #201
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1004390464
branch
from
October 23, 2026 19:20
fd1352a to
8934c4f
Compare
…Result` With Crubit's `movable_return_values` feature, `cc_bindings_from_rs` returns `rs_std::Result<T, E>` by value wrapped in `::rs::Movable<rs_std::Result<T, E>>`. Because C++ template argument deduction on `MapResult(rs_std::Result<T, E>&&)` does not consider user-defined conversion operators on `::rs::Movable`, add a forwarding overload that unwraps `Wrapper<rs_std::Result<T, E>>&&` into `rs_std::Result<T, E>` before delegating to `MapResult`. PiperOrigin-RevId: 1005781644
copybara-service
Bot
force-pushed
the
test_1004390464
branch
from
October 23, 2026 19:29
8934c4f to
9fda495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
rs::Movable<rs_std::Result<T, E>>inelf_bridge.cc'sMapResultWith Crubit's
movable_return_valuesfeature,cc_bindings_from_rsreturnsrs_std::Result<T, E>by value wrapped in::rs::Movable<rs_std::Result<T, E>>. Because C++ template argument deduction onMapResult(rs_std::Result<T, E>&&)does not consider user-defined conversion operators on::rs::Movable, add a forwarding overload that unwrapsWrapper<rs_std::Result<T, E>>&&intors_std::Result<T, E>before delegating toMapResult.