Repository navigation
Replace auto and chained .build().value() with explicit rs_std::Result types in security/regex - #202
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1004390468
branch
from
October 23, 2026 19:20
3a6dd87 to
7852278
Compare
…Result` types in `security/regex` With Crubit's `movable_return_values` feature, `cc_bindings_from_rs` returns `rs_std::Result<T, E>` by value wrapped in `::rs::Movable<rs_std::Result<T, E>>`, which implicitly converts to `rs_std::Result<T, E>` via `operator rs_std::Result<T, E>() &&`. Using `auto` or calling `.value()` directly on the return value of `build()` accesses `::rs::Movable` instead of `rs_std::Result`. Materializing the result into an explicit `rs_std::Result<...>` variable works both before and after `movable_return_values` is enabled. PiperOrigin-RevId: 1005780449
copybara-service
Bot
force-pushed
the
test_1004390468
branch
from
October 23, 2026 19:26
7852278 to
6be4c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
autoand chained.build().value()with explicitrs_std::Resulttypes insecurity/regexWith Crubit's
movable_return_valuesfeature,cc_bindings_from_rsreturnsrs_std::Result<T, E>by value wrapped in::rs::Movable<rs_std::Result<T, E>>, which implicitly converts tors_std::Result<T, E>viaoperator rs_std::Result<T, E>() &&. Usingautoor calling.value()directly on the return value ofbuild()accesses::rs::Movableinstead ofrs_std::Result. Materializing the result into an explicitrs_std::Result<...>variable works both before and aftermovable_return_valuesis enabled.