Require asm goto support unconditionally for rseq. - #535
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_967677836
branch
4 times, most recently
from
August 25, 2026 14:54
665940d to
b2585b7
Compare
Clang 11 (which added asm goto support) was released almost six years ago, and GCC has supported this since about 2010. Clean it up so that the code is easier to read. Unfortunately, GCC has grown a new regression in the meantime (supposedly wrong code from GCC 14, ICE from GCC 16), so add a smaller workaround until it is hopefully fixed in 16.3. PiperOrigin-RevId: 970561435
copybara-service
Bot
force-pushed
the
test_967677836
branch
from
August 25, 2026 15:11
b2585b7 to
ea99e09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require asm goto support unconditionally for rseq.
Clang 11 (which added asm goto support) was released almost
six years ago, and GCC has supported this since about 2010.
Clean it up so that the code is easier to read.
Unfortunately, GCC has grown a new regression in the meantime
(supposedly wrong code from GCC 14, ICE from GCC 16), so add
a smaller workaround until it is hopefully fixed in 16.3.