Repository navigation
Extend limited-divisor-space and variable power-of-two optimizations to sdiv. - #5161
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1001108234
branch
from
October 16, 2026 22:10
c05a924 to
e5c4032
Compare
…to sdiv. Signed division (`sdiv`) previously handled only single constant divisors inline in `MatchSignedDivide` and variable power-of-two divisors in a separate `MatchSDivByVariablePowerOfTwo` helper, missing lookup-table generation when range or state analysis restricts a signed divisor to a small set of values. Generalize `MatchWithLimitedDivisorSpace` and its supporting division helpers (`DivisionConstants`, `DivisionByPowerOfTwo`, `ComputeDivisionConstants`, `MakeDivByZeroResult`, `GetPow2Shift`, `MakePow2ShiftNode`, `MakeDivByConstantValues`, `MakeDivByPowerOfTwo`, `MakeDivLutNode`, and `GetPow2DivStrategy`) to handle both `Op::kUDiv` and `Op::kSDiv`. Signed divisors with power-of-two magnitude (including `±1`, `±2^k`, and `MinSigned`) use shift/negate operations, while arbitrary signed constants use multiplication by invariant integers and arithmetic shifts. Remove the duplicate constant-divisor logic in `MatchSignedDivide` and the standalone `MatchSDivByVariablePowerOfTwo` helper. PiperOrigin-RevId: 1001108234
copybara-service
Bot
force-pushed
the
test_1001108234
branch
from
October 16, 2026 23:35
e5c4032 to
9a4b88b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend limited-divisor-space and variable power-of-two optimizations to sdiv.
Signed division (
sdiv) previously handled only single constant divisors inline inMatchSignedDivideand variable power-of-two divisors in a separateMatchSDivByVariablePowerOfTwohelper, missing lookup-table generation when range or state analysis restricts a signed divisor to a small set of values.Generalize
MatchWithLimitedDivisorSpaceand its supporting division helpers (DivisionConstants,DivisionByPowerOfTwo,ComputeDivisionConstants,MakeDivByZeroResult,GetPow2Shift,MakePow2ShiftNode,MakeDivByConstantValues,MakeDivByPowerOfTwo,MakeDivLutNode, andGetPow2DivStrategy) to handle bothOp::kUDivandOp::kSDiv. Signed divisors with power-of-two magnitude (including±1,±2^k, andMinSigned) use shift/negate operations, while arbitrary signed constants use multiplication by invariant integers and arithmetic shifts. Remove the duplicate constant-divisor logic inMatchSignedDivideand the standaloneMatchSDivByVariablePowerOfTwohelper.