Repository navigation
Conversation
nsalminen
force-pushed
the
perf/horizontal-placement
branch
from
November 16, 2026 19:26
e4b7688 to
b7ea572
Compare
… in placeOnHorizontalSurface
nsalminen
force-pushed
the
perf/horizontal-placement
branch
from
November 16, 2026 19:37
b7ea572 to
39721af
Compare
nsalminen
marked this pull request as ready for review
November 16, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces main-thread CPU overhead during
placeOnHorizontalSurface()candidate evaluation and blocked placement retries on XR devices:.boundingBoxrenderables as well asMeshgeometries) and evaluates candidate transforms without repeatedBox3.setFromObject()scene-subtree traversals.XRPlanepolygonVector2arrays in aWeakMapkeyed bylastChangedTime, and throttles unchanged retry sweeps to 250ms intervals (waking immediately when detected planes change) instead of re-running full obstacle/grid checks on every 72/90 Hz frame.0.5mto0.75mwith a soft comfort penalty inside1.1mso large models aren't placed uncomfortably close to the headset.Type of Change
Media / Screen Recordings & Screenshots (If Applicable)
Checklist