feat(gax): implement queryStatusCallable for resumable uploads - #14155
Draft
whowes wants to merge 1 commit into
Draft
feat(gax): implement queryStatusCallable for resumable uploads#14155whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
whowes
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for querying the status of an active resumable upload session by introducing QueryStatusRequest and QueryStatusResponse and implementing queryStatusCallable() in HttpJsonResumableUploadClient. Feedback on the changes highlights a critical issue where the client only accepts 2xx status codes for status queries, whereas Google's resumable upload protocol returns 308 Resume Incomplete for active uploads. The reviewer suggests updating the status check to accept 308 and adjusting the unit tests to use 308 instead of 200 for mock responses.
whowes
changed the title
whowes
force-pushed
the
whowes/resumable-upload-query
branch
from
August 21, 2026 00:37
44dc342 to
8cfb56d
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides the ability for callers to query the server for the committed byte offset so far and detect if the upload has already finalized. This is needed for resumable uploads to be able to recover from occasional interruptions.