Conversation
If the default master's userData had a ufo2ft filters list, we only set PROPAGATE_ANCHORS when propagateAnchors appeared in it. But glyphsLib propagates anchors before it ever looks at filters, gated only by the "Propagate Anchors" custom parameter (default true), so any source with that userData key (e.g. anything produced by ufo2glyphs) silently lost propagation in fontc while fontmake still propagated. With this patch, the custom parameter alone decides; a propagateAnchors filter entry is a no-op, as in glyphsLib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the default master's
userDatahad a ufo2ft filters list, we only set PROPAGATE_ANCHORS when propagateAnchors appeared in it. But glyphsLib propagates anchors before it ever looks at filters, gated only by the "Propagate Anchors" custom parameter (default true), so any source with that userData key (e.g. anything produced by ufo2glyphs) silently lost propagation in fontc while fontmake still propagated.With this patch, the custom parameter alone decides; a propagateAnchors filter entry is a no-op, as in glyphsLib.
This fixes major layout diffs in NotoSans.