Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Feed uses
banner_imageandsize_in_bytes, but the structs currently usebanner_andsize. As a result, conforming input loses those fields and generated output uses names that readers do not recognize.Correct both struct tags and add round-trip tests against the specified JSON names. Both tests fail before the fix. Full
go test -race -cover ./...passes (92.7% coverage), as doesgo vet ./....Specification: https://www.jsonfeed.org/version/1.1/#items-a-nameitems-a and https://www.jsonfeed.org/version/1.1/#attachments