Repository navigation
refactor(node): manage platform packages with npm workspaces - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the four native platform packages as tracked npm workspaces instead of generating them with
pack-node.py. Update release version synchronization, CI and maintainer documentation to pack the workspaces while preserving exact optional dependency versions and platform constraints.Replace the previous Node fixture, API-surface and packaging test files with a real CLAP inference test matching
rust/tests/clap.rs. The test imports the checkout directly withrequire('..'), downloads the quantized model through@huggingface/hubinto the repository root, compares the dog audio against both descriptions, and releases the model afterward. Remove the unused test TypeScript configuration.Exclude tests and audio fixtures from published packages. Remove installed-package testing and validate archive payloads, licenses, platform constraints and matching versions with
validate-node-packages.py; release validation requires all four runtime archives. Also simplify the Rust README and update its badges.Validation on macOS ARM64:
npm testpassed against the checkout; dog score0.9999998353, vacuum-cleaner score0.0000001647.--require-allrejects an incomplete release archive set.index.js,index.d.ts,README.md,LICENSEandpackage.json.Linux and Windows checkout inference remains covered by CI.