Repository navigation
fix(deps): force minimatch ^11.0.1 for GHSA-g3hv-75wg-m249 - #321
Closed
luca-gr4vy wants to merge 1 commit into
Closed
luca-gr4vy wants to merge 1 commit into
luca-gr4vy wants to merge 1 commit into
Conversation
minimatch >=7 <11.0.1 is vulnerable to ReDoS via globparts amplification, with no backport. Parents (typescript-estree, builder-bob's glob, module-resolver's glob) still pin ^8/^10, so add path-scoped yarn resolutions. minimatch 3.x consumers are unaffected. Dependabot alerts: - https://github.com/gr4vy/gr4vy-react-native/security/dependabot/321 - https://github.com/gr4vy/gr4vy-react-native/security/dependabot/322 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The minimatch 11 override is incompatible with glob’s wildcard handling, causing Bob to find no source files and breaking clean JavaScript builds.
1 open issue
What changed in this PR
This PR addresses minimatch ReDoS advisory GHSA-g3hv-75wg-m249 in the library’s development dependencies and example app.
Changes:
- Adds targeted Yarn resolutions for minimatch under TypeScript tooling, Bob, and Babel module resolver.
- Updates both lockfiles to minimatch 11.0.8 while retaining existing 3.1.5 dependencies.
| File | Description |
|---|---|
yarn.lock |
Updates minimatch and its transitive dependencies. |
package.json |
Adds minimatch resolutions for TypeScript tooling and Bob. |
example/yarn.lock |
Replaces minimatch 8.x and 10.x with 11.0.8. |
example/package.json |
Adds minimatch resolutions for TypeScript tooling and Babel module resolver. |
Review effort: Balanced
| }, | ||
| "resolutions": { | ||
| "**/@typescript-eslint/typescript-estree/minimatch": "^11.0.1", | ||
| "react-native-builder-bob/glob/minimatch": "^11.0.1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Dependabot alerts 321 (
example/yarn.lock) and 322 (yarn.lock): minimatch ReDoS, GHSA-g3hv-75wg-m249.@typescript-eslint/typescript-estree(^10),glob9 underbabel-plugin-module-resolver(^8),glob13 underreact-native-builder-bob(^10).resolutionsscoped by path, so the minimatch 3.x used by eslint 8 and glob 7 stays as it is.minimatch11.0.8 + 3.1.5.>= 20. The exports these parents import are unchanged.Verified:
bob buildOK.eslintruns (it uses typescript-estree).yarn auditshows no minimatch findings in either workspace.🤖 Generated with Claude Code