-
Notifications
You must be signed in to change notification settings - Fork 58
feat(plugin-docs-cli): align preview with catalog-website layout #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,494
−531
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ae9b0b8
feat(plugin-docs-cli): resolve plugin readme path
sunker 87ed0a5
feat(plugin-docs-cli): port catalog docs nav helpers
sunker 45fe397
feat(plugin-docs-cli): align preview with catalog-website layout
sunker 03873ab
Merge remote-tracking branch 'origin/main' into eriksundell/plugin-do…
sunker ce4cfd8
fix(plugin-docs-cli): sanitize preview readme like gcom
sunker 7d1303d
fix(plugin-docs-cli): re-read preview readme on each request
sunker 8f5d1b3
Enhance input tag handling for disabled checkboxes
sunker 01bf235
Normalize file path separators in resolveRelativePath
sunker 5d0a367
fix(plugin-docs-cli): restore resolveRelativePath signature
sunker 645df62
fix(plugin-docs-cli): watch docs folder so live reload fires
sunker d283bfe
fix(plugin-docs-cli): read xss whitelist from default export
sunker 403c487
refactor(plugin-docs-cli): use a DOCS_BASE constant for the docs root
sunker 576b254
test(plugin-docs-cli): add unit tests for the docs nav helpers
sunker 7d052ba
Merge remote-tracking branch 'origin/main' into eriksundell/plugin-do…
sunker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| title: Overview | ||
| description: Landing page for the test docs | ||
| sidebar_position: 0 | ||
| --- | ||
|
|
||
| Welcome to the test docs. See the [guide](./guide) for details, or visit [Grafana](https://grafana.com). |
15 changes: 15 additions & 0 deletions
15
packages/plugin-docs-cli/src/__fixtures__/test-readme/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Test Plugin | ||
|
|
||
| This is the plugin readme, shown on the Overview tab. | ||
|
|
||
| ## Getting started with `grafana-cli` | ||
|
|
||
| Install the plugin and open Grafana. | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| Run Grafana v10 or later. | ||
|
|
||
| ## Screenshots | ||
|
|
||
| See below. |
6 changes: 6 additions & 0 deletions
6
packages/plugin-docs-cli/src/__fixtures__/unsafe-slug-docs/index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| title: Overview | ||
| description: Landing page for the unsafe-slug fixture | ||
| --- | ||
|
|
||
| Landing page for the unsafe-slug fixture. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.