Repository navigation
Keep SortedDict consistent when setdefault ordering fails - #262
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SortedDict.setdefault writes into the underlying dict before inserting the key into the sorted index. If keys cannot be compared, or the sort-key function raises, the dictionary keeps a key missing from iteration and fails its consistency check.
Insert into the sorted index first, matching setitem. Two regression cases fail before; an existing-key control also ensures its sort key is not recomputed. Full tests/doctests: 369 pass on Python 3.10 and 3.12. Source Ruff passes with the supported Python 3.8 target. The default Ruff run has five existing B905 findings in sortedlist.py (also addressed by open #259); format check reports one existing adjacent-string formatting difference outside this diff. Final diff/whitespace checks pass.
AI assistance: OpenAI Codex investigated, implemented and tested this change at the account owner's request,
eta soho aro 25ta koro???. No independent human review is claimed.