feat(query): add temporal_relation and evidence_request plan steps - #147
Open
Sidra-009 wants to merge 1 commit into
Open
feat(query): add temporal_relation and evidence_request plan steps#147Sidra-009 wants to merge 1 commit into
Sidra-009 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Related to #84
Summary
Extends the local-model query-planning path with support for temporal
relations, occurrence modes, and evidence-delivery requests, per the
examples listed in #84.
OccurrenceMode(first/best/all) toSearchMomentsPlanStep.TemporalRelationPlanStepfor before/after/during queries betweentwo searches.
EvidenceRequestPlanStepfor requesting a board or exactclips/frames as evidence.
temporal_relations_allowed,evidence_requests_allowed) toQueryPlanningRequest, defaulting toFalse._default_plan,_valid_plan, andGroundedQueryService.planin
query_service.pyto accept and validate the new step types, withthe same default-
Falseopt-in behavior.This is an internal, application-layer change: no CLI, HTTP, MCP, or
frontend surface calls the new parameters yet, and existing callers are
unaffected since all new parameters default to
False.Out of scope for this PR (left as follow-up per #84, to keep this PR
focused on one outcome):
plan, for reproducibility.
descriptions.
Validation
uv run --no-sync ruff check .All checks passed!
65 passed in 3.43s
The full
pytest -qsuite could not be run end-to-end locally: severalunrelated test modules fail to collect because of pre-existing missing
optional dependencies (
torch,streamlit,fastapi,httpx,cryptography,alembic,numpy, etc.) unrelated to this change, anduv sync --extra local-workertimed out downloadingtorchdue to alocal network issue. These gaps were present before this change as well.