Skip to content

move getSCParameters to commons ui - #4022

Open
EtienneLt wants to merge 4 commits into
mainfrom
move-getsc-to-commons-ui
Open

EtienneLt wants to merge 4 commits into
mainfrom
move-getsc-to-commons-ui

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: fe3f4e43-163e-4bd0-b9d0-5f0926358aba

📥 Commits

Reviewing files that changed from the base of the PR and between 571da3a and d9ccc0f.

📒 Files selected for processing (2)
  • src/components/parameters-tabs.tsx
  • src/services/study/short-circuit-analysis.ts
💤 Files with no reviewable changes (1)
  • src/services/study/short-circuit-analysis.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/parameters-tabs.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change moves short-circuit parameter getter imports to @gridsuite/commons-ui and removes their exports from the study service. Short-circuit setter functions remain in the study service.

Changes

Short-circuit parameter wiring

Layer / File(s) Summary
Parameter helper import migration
src/components/parameters-tabs.tsx, src/services/study/short-circuit-analysis.ts
Parameter getters are imported from @gridsuite/commons-ui. The study service retains the setter and no longer exports the getter helpers.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d9ccc

The helper import relocation has no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only the PR template and does not summarize the changes. It is too vague to confirm the intended scope. Add a brief summary that states the short-circuit parameter getter functions moved to Commons UI and were removed from the study service module.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: moving the short-circuit parameter getter to Commons UI. It is concise and related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants