Skip to content

add filter for voltage on vl in nad - #4191

Merged
EtienneLt merged 4 commits into
mainfrom
add-nad-vl-voltage-filter
Sep 11, 2026
Merged

EtienneLt merged 4 commits into
mainfrom
add-nad-vl-voltage-filter

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b3a4ee4d-069b-4bdc-9188-26006e682195

📥 Commits

Reviewing files that changed from the base of the PR and between 0eba806 and 700ec85.

📒 Files selected for processing (2)
  • src/translations/messages-en.ts
  • src/translations/messages-fr.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/translations/messages-en.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The NAD information filter replaces the voltage-level name option with a voltage-level voltage option. The filter state, selector, default visibility, panel wiring, filter row, and English and French translations are updated. Voltage-level names remain visible.

Changes

NAD voltage-level filter

Layer / File(s) Summary
Update filter state and diagram wiring
src/components/workspace/diagrams/nad/use-nad-info-filter.ts, src/components/workspace/panel-contents/diagrams/nad/nad-panel-content.tsx
The filter removes voltageLevelInfo, retains voltageLevelVoltage, and keeps voltage-level names visible.
Expose the voltage-level voltage option
src/components/workspace/diagrams/nad/nad-info-filter.tsx, src/translations/messages-en.ts, src/translations/messages-fr.ts
The filter row and English and French translations use voltageLevelVoltage labels.

Suggested reviewers: mathieu-deharbe, benrejebmoh

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 700ec

The NAD filter update has no unresolved merge-blocking risk in the reviewed changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only the PR template and does not provide a meaningful summary of the changes. Add a brief summary stating that the NAD now filters voltage levels by voltage and that the previous voltage-level information option was removed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding a voltage filter for voltage levels in the NAD. It is concise and related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@Mathieu-Deharbe
Mathieu-Deharbe self-requested a review September 10, 2026 09:13

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't manage to join Michaël to ask him but I don't think that you did what he wanted : here "voltage level info" hide both the name and the voltage. I think there should be a "Voltage level name" which only hides the name and the "voltage level voltages" that you already added.

I also think that "info" doesn't sound very professional.

Nevermind if Michael already validated this.

{ key: 'activePowerArrow', labelId: 'nadInfoActivePowerArrow' },
{ key: 'reactivePowerArrow', labelId: 'nadInfoReactivePowerArrow' },
{ key: 'voltageLevelName', labelId: 'nadInfoVoltageLevelName' },
{ key: 'voltageLevelInfo', labelId: 'nadInfoVoltageLevelInfo' },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change from voltageLevelName to voltageLevelInfo ? It looks like name was fine and more precise.

| 'activePowerArrow'
| 'reactivePowerArrow'
| 'voltageLevelName';
| 'voltageLevelInfo'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same : why not voltageLevelName ?

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@sonarqubecloud

Copy link
Copy Markdown

@EtienneLt
EtienneLt merged commit 447a776 into main Sep 11, 2026
5 of 6 checks passed
@EtienneLt
EtienneLt deleted the add-nad-vl-voltage-filter branch September 11, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants