add filter for voltage on vl in nad - #4191
Conversation
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe NAD information filter replaces the voltage-level name option with a voltage-level voltage option. The filter state, selector, default visibility, panel wiring, filter row, and English and French translations are updated. Voltage-level names remain visible. ChangesNAD voltage-level filter
Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The NAD filter update has no unresolved merge-blocking risk in the reviewed changes. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mathieu-Deharbe
left a comment
There was a problem hiding this comment.
I didn't manage to join Michaël to ask him but I don't think that you did what he wanted : here "voltage level info" hide both the name and the voltage. I think there should be a "Voltage level name" which only hides the name and the "voltage level voltages" that you already added.
I also think that "info" doesn't sound very professional.
Nevermind if Michael already validated this.
| { key: 'activePowerArrow', labelId: 'nadInfoActivePowerArrow' }, | ||
| { key: 'reactivePowerArrow', labelId: 'nadInfoReactivePowerArrow' }, | ||
| { key: 'voltageLevelName', labelId: 'nadInfoVoltageLevelName' }, | ||
| { key: 'voltageLevelInfo', labelId: 'nadInfoVoltageLevelInfo' }, |
There was a problem hiding this comment.
Why did you change from voltageLevelName to voltageLevelInfo ? It looks like name was fine and more precise.
| | 'activePowerArrow' | ||
| | 'reactivePowerArrow' | ||
| | 'voltageLevelName'; | ||
| | 'voltageLevelInfo' |
There was a problem hiding this comment.
Same : why not voltageLevelName ?
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|



PR Summary