Conversation
A change to the activation of a composite, global or for a root network tag, was propagated to everything it holds, overwriting the state of each sub modification. A composite and its content now each carry their own. Nothing changes when applying the modifications: a composite the tag deactivates, or that is deactivated globally, is already left out before its content is reached, and the content is filtered one modification at a time by CompositeModification. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
flomillot
changed the title
flomillot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A composite and each of the modifications it holds now carry their own activation, global and per root network
tag: changing one no longer overwrites the others.
How the modifications are applied is untouched — a deactivated composite is already left out before its
content is reached.
Goes with gridsuite/study-server#1102 and gridsuite/commons-ui#1354.