feat: make composed modifications standalone - #229
Open
TheMaskedTurtle wants to merge 6 commits into
Open
TheMaskedTurtle wants to merge 6 commits into
TheMaskedTurtle wants to merge 6 commits into
Conversation
TheMaskedTurtle
requested review from
EtienneLt,
SlimaneAmar and
etiennehomer
as code owners
September 3, 2026 07:40
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
achour94
approved these changes
Sep 4, 2026
TheMaskedTurtle
force-pushed
the
jorism/refactor/prepare-to-filter-loader
branch
from
September 4, 2026 12:02
f37417c to
0be7c98
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
…bstractModification Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
TheMaskedTurtle
force-pushed
the
jorism/refactor/prepare-to-filter-loader
branch
from
September 7, 2026 13:05
52e86e1 to
251f265
Compare
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make composed modifications (tabular, composite and reference) standalone, meaning that will not depend on ModificationInfos anymore. These instances should be replace by AbstractModification instances.