Repository navigation
Superseded: Stripe.js update and Vitest fixes - #2400
Closed
dependabot[bot] wants to merge 6 commits into
Closed
dependabot[bot] wants to merge 6 commits into
dependabot[bot] wants to merge 6 commits into
Conversation
Bumps [@stripe/stripe-js](https://github.com/stripe/stripe-js) from 9.17.0 to 10.0.0. - [Release notes](https://github.com/stripe/stripe-js/releases) - [Commits](stripe/stripe-js@v9.17.0...v10.0.0) --- updated-dependencies: - dependency-name: "@stripe/stripe-js" dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
groupthinking
requested changes
Oct 28, 2026
groupthinking
left a comment
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Review at head bb8c28e0: this PR changes apps/web/package.json without updating the root package-lock.json, and current-head build, lint, and frontend test checks fail. Reconcile the workspace lockfile with the manifest, then rerun the checks before approval.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
previously approved these changes
Oct 28, 2026
groupthinking
left a comment
groupthinking
left a comment
Owner
There was a problem hiding this comment.
Code review at b9d3666153213e28dc5b56660d74b58ece8afc15: the earlier manifest/lockfile and failing-check concerns are resolved. The two-file diff updates @stripe/stripe-js to 10.2.0; clean install, web tests (1,520 passed, 28 skipped), lint, type check, and production build passed locally, and current hosted checks show 26 passed and 3 skipped. A repository source search found no import or loader call for Stripe.js; current browser checkout paths redirect to server-provided Checkout URLs. The Stripe.js 10 Payment Request Button and Elements changes therefore do not alter a current in-app call site.
I approve the code change at this head. This is not a merge recommendation or a payment transaction verdict. The shared dependency-review job still fails after a 3-base/1-head snapshot comparison and has no reliable evidence artifact. Keep the PR open until that check is corrected. Any future client-side Stripe.js integration needs its own browser test.
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
Author
|
A newer version of @stripe/stripe-js exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
groupthinking
changed the title
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
changed the title
Contributor
🔍 PR Validation |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update is superseded by two reviewed replacements:
mainat67bf5f1ed600261f4739ca679c00cb80f50e4f5f. It updates Stripe.js to 10.2.1, superseding this PR's 10.2.0 resolution and older range.835cbe73385b2e32cc3be39fe0641cb9e5f1e216, preserves this PR's nine complete root development lock records: Vitest and seven @vitest packages at 4.1.12, plus tinyrainbow 3.2.0. That PR is approved and remains open; these test-tooling changes are not yet merged.The complete two-file diff and all eleven changed lock records were compared with those replacements. No unique application change remains in #2400. Closing this duplicate does not merge either branch or waive the remaining dependency findings. The original commits and this PR's discussion remain available.