Repository navigation
fix(studio): stop local analysis across client stages - #2662
Draft
groupthinking wants to merge 1 commit into
Draft
groupthinking wants to merge 1 commit into
groupthinking wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2660
Outcome
Cancel immediately stops the local analysis view and restores Run. Pack requests, polling waits and workflow kickoff receive cancellation, and a stopped client cannot advance into a later stage or let stale responses replace the active UI.
The message is explicit: “Analysis stopped in this browser. Server work already accepted may continue.”
Scope
Risk and rollback
Risk: medium. Cancellation crosses several async stages and UI state changes. Regression cases cover abort during active requests, response-body resolution, delay, stage transitions, late completion and replacement runs. A separate reviewer found the initially displaced kickoff timeout; it is corrected and covered.
Rollback: prepare a reviewed revert. It restores the incomplete client-cancellation behavior. No merge or deployment is authorized by this draft.
Verification
Final head:
e9fc9e132fa47d6a281992fc1be204e4323f73eb. GitHub tree6484726d8141c584b765ae2bf60a6f1f54ee7ad3matches the local publication tree exactly. Source baseline:0e4b269ebb841e8912d7adf0f785f17e842455bc.Environment: Node 24.22.1, npm 11.9.0, app Vitest 5.1.0. Frozen install; manifests and lockfile unchanged.
npm exec --workspace=apps/web -- vitest run src/lib/__tests__/emit-video-pack.test.ts src/lib/__tests__/studio-workflow.test.ts src/store/__tests__/dashboard-store.test.ts src/store/__tests__/dashboard-store.persistence.test.ts src/components/__tests__/OneLoopStudio.cancellation.test.tsx src/components/__tests__/OneLoopStudio.three-panel.test.tsx src/components/__tests__/OneLoopStudio.job-strip.test.tsx src/components/__tests__/OneLoopStudio.build-live.test.tsx --maxWorkers=2 --reporter=dot: 97 passed in eight files, exit 0.npm --workspace=apps/web test -- --maxWorkers=2: 1,581 passed / 28 skipped across 172 files, exit 0.e3eada50efabfbdd0895cb589a0f930c89e72978equals the clean three-way tree calculation for both local review branches. No branch merge was performed.Production evidence
No live extraction, model request, deployment, browser production mutation or server cancellation was executed. This is client cancellation; work already accepted by the server may continue. Provider-side deployment absence is not independently certified because Vercel project lookup returned 404 through the current connection.
Current-head follow-through (2026-11-12)
e9fc9e132fa47d6a281992fc1be204e4323f73eb; fetched Git commit tree6484726d8141c584b765ae2bf60a6f1f54ee7ad3matches the isolated local test tree.No Vercel preview deployment became available for PR SHA e9fc9e132fa47d6a281992fc1be204e4323f73eb.Exit 1; E2E tests were skipped. Repository Reconciliation run 43332213723 was cancelled; that metadata-report cancellation is not a source-test verdict.The required preview E2E gate is preserved. Both exact branch names remain disabled in
vercel.jsonandapps/web/vercel.json; no deployment, paid extraction, merge, check bypass, or CI weakening was performed. A hosted preview requires separate deployment authorization.Agent handoff
Codex owns current-head CI/review follow-through and fixes. Keep this draft unmerged and undeployed. Readiness correction is PR #2661.