refactor(tui): Forward identity to gen ResourceBehaviour - #1976
Merged
Conversation
PR #1975 added the generated mechanical tier for the identity resources. Thin the hand-written `ResourceBehaviour` impls to one-line forwarders onto `super::generated::<r>::Generated::<method>`, keeping only custom logic: - `users.rs`: `action_to_request` enable/disable toggle, `confirm_request` delete prompt, `filter_carry_action` drilldown into application credentials, `handle_mutation_response`, and the two `TryFrom<&serde_json::Value>` builders. - `projects.rs`: `filter_carry_action` translating `SwitchToProject` into a `CloudChangeScope`. - `groups.rs`: `confirm_request` delete prompt, `filter_carry_action` drilldown into group users, and its two `TryFrom` builders. `group_users.rs` and `application_credentials.rs` are nested resources the generator does not emit and are left untouched. Test title expectations move to the generator's prefix-stripped form ("Users", "Projects", "Groups"). Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
force-pushed
the
tui-thin-identity
branch
from
September 3, 2026 16:14
c6799bf to
db8b0b3
Compare
gtema
enabled auto-merge (squash)
September 3, 2026 16:15
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1975 added the generated mechanical tier for the identity resources.
Thin the hand-written
ResourceBehaviourimpls to one-line forwardersonto
super::generated::<r>::Generated::<method>, keeping only customlogic:
users.rs:action_to_requestenable/disable toggle,confirm_requestdelete prompt,filter_carry_actiondrilldown intoapplication credentials,
handle_mutation_response, and the twoTryFrom<&serde_json::Value>builders.projects.rs:filter_carry_actiontranslatingSwitchToProjectinto a
CloudChangeScope.groups.rs:confirm_requestdelete prompt,filter_carry_actiondrilldown into group users, and its two
TryFrombuilders.group_users.rsandapplication_credentials.rsare nested resourcesthe generator does not emit and are left untouched. Test title
expectations move to the generator's prefix-stripped form ("Users",
"Projects", "Groups").
Assisted-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com