Repository navigation
fix: support WebSocket timeouts on Python 3.10 - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python >=3.10 is declared as supported, but existing WebSocket probes raise AttributeError on Python 3.10 because asyncio.timeout is unavailable. The previous CI run reported 8 failed and 5 passed.
Use asyncio.wait_for around the complete connect-and-receive coroutine, preserving one timeout budget per attempt. Catch asyncio.TimeoutError for Python 3.10 while preserving timeout reporting and external cancellation.
Add regression tests for a shared timeout budget across multiple messages and cancellation without retry.
Validation: installed .[dev] in isolated Python 3.10.21, 3.11.16 and 3.12.14 environments; pytest -q: 15 passed on each, with websockets 15.0.1. These are local test results; this branch has no Actions workflow because main has none. The separate CI PR #2 is unchanged.
Only src/api_ws_suite/ws_probe.py and tests/test_ws_probe.py change. No dependency, metadata, README, or workflow changes. No merge performed.