clamp vsnprintf result before copying in log_printf - #9398
Open
Nashit-h wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9398 +/- ##
==========================================
+ Coverage 70.14% 70.19% +0.04%
==========================================
Files 261 261
Lines 79388 79396 +8
Branches 19357 19358 +1
==========================================
+ Hits 55690 55729 +39
- Misses 17874 17885 +11
+ Partials 5824 5782 -42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcourteaux
previously requested changes
Aug 27, 2026
mcourteaux
left a comment
Contributor
There was a problem hiding this comment.
Good catch, although I believe the fix is not 100% correct.
alexreinking
approved these changes
Aug 29, 2026
alexreinking
left a comment
Member
There was a problem hiding this comment.
I fixed the usage manually. Thanks for catching the problem in the first place!
alexreinking
dismissed
mcourteaux’s stale review
August 29, 2026 17:39
I made the requested changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp message_size to the bytes that actually fit (and bail on the negative error return) before the copy. log_printf backs halide_print/halide_error on the DSP, so an over-long printed or error string reaches it.