Upgrade UI template tooling - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33e3cb6883
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Freshly generated Vite projects could not run ESLint because the TypeScript configuration loader dependency was missing.
Freshly generated Rsbuild projects could resolve an incompatible combination of Rsbuild 1 and
@rsbuild/plugin-vue2, causing the build to fail. Rsbuild projects also lacked the Vite plugins required to run Vue SFC unit tests.This update fixes those failures while keeping the Halo-specific UI plugin entry and bundling behavior unchanged.
Testing
pnpm check./gradlew buildin generated Vite and Rsbuild projectspnpm buildin generated Vite and Rsbuild UI projectspnpm lintin generated Vite and Rsbuild UI projectspnpm exec prettier --check src/pnpm audit --jsonreported no known vulnerabilitiesnpm pack --dry-run --jsongit diff --check