Conversation
LIlGG
requested changes
Sep 22, 2026
LIlGG
left a comment
Member
There was a problem hiding this comment.
同时,调大 http 编码缓存区之后, base64 仍可能触发 Jackson 的字符串长度限制,可能报错 StreamConstraintsException ,建议一并处理一下。
Comment on lines
49
to
+55
| public static WebClient.Builder webClientBuilder(AiProvider provider) { | ||
| return WebClient.builder() | ||
| .clientConnector(new ReactorClientHttpConnector(httpClient(provider))); | ||
| return webClientBuilder(provider, providerMaxInMemorySize(provider)); | ||
| } | ||
|
|
||
| public static WebClient.Builder discoveryWebClientBuilder(AiProvider provider) { | ||
| return webClientBuilder(provider) | ||
| return webClientBuilder(provider, DISCOVERY_MAX_IN_MEMORY_SIZE); | ||
| } |
Member
There was a problem hiding this comment.
不建议对 webClientBuilder 以及 discoveryWebClientBuilder 做修改。我建议新增一个 image 专用的 imageWebClientBuilder 来处理此问题。
| * can be several megabytes) and fail with a {@code DataBufferLimitException}. Providers that | ||
| * return such payloads can raise the limit through {@code AiProvider.spec.maxInMemorySize}. | ||
| */ | ||
| public static final int DEFAULT_MAX_IN_MEMORY_SIZE = 256 * 1024; |
Member
There was a problem hiding this comment.
改为 image 专用的内存大小设置即可,并且我建议对 image 设置一个默认且合理的缓存区大小,这样可以减少用户的设置,避免用户报错后再去修改。
根据 https://developers.openai.com/api/reference/cli/resources/images/methods/generate 它一次请求最多支持 10 张图,因此我建议设置为 64 * 1024 * 1024 。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
AI Foundation 的 provider HTTP 客户端使用 Spring 默认的 256 KB 内存缓冲上限。图片生成接口内联 base64 图片时(例如 gpt-image-* 总是返回 b64_json,单张图片可达数 MB)会超出该上限,导致请求以 DataBufferLimitException 失败。
本 PR 为 AiProvider 增加可选的 spec.maxInMemorySize(字节):
Does this PR introduce a user-facing change?