Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
- Preserve newlines and consecutive spaces when editing plain-text comments created from the Console textarea editor - Show a dedicated message when saving fails with 404 on Halo versions without the content endpoints - Allow canceling while the latest content is loading and retrying after a load failure - Focus the editor once it is ready and confirm before discarding unsaved changes - Rename the generic close event to edit-close - Cover the new content endpoints and plain-text conversion with tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e68dda894f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -12,3 +12,31 @@ export function cleanHtml(content?: string) { | |||
| }, | |||
| }); | |||
| } | |||
There was a problem hiding this comment.
When a plain-text Console comment contains literal code such as Use <T> here, this pattern classifies the entire value as HTML. Tiptap then parses <T> as an element rather than text, so the literal token disappears and saving any subsequent edit silently corrupts the original comment. Determine the source format without relying on a tag-shaped substring, or escape raw plain text before passing it to Tiptap.
Useful? React with 👍 / 👎.
| } catch { | ||
| this.loadFailed = true; |
There was a problem hiding this comment.
If another administrator fully deletes the comment after this stale list row was rendered but before the editor fetch completes, the resource endpoint returns 404 and this catch reports a retryable load failure. Retrying can never succeed, and the dedicated deleted state is only reached when a still-terminating resource is returned with deletionTimestamp; inspect a 404 here and show the deleted-target state instead.
Useful? React with 👍 / 👎.
- Join plain-text lines with hard breaks instead of paragraphs so line spacing matches the pre-wrap rendering of existing comments - Keep existing HTML entities encoded once and expand tabs - Treat angle-bracket text that cleaning would strip as plain text - Record the editor-normalized content as the dirty-check baseline so undoing back to the original no longer prompts or enables save - Cover concurrent deletion in the 404 save error message
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab186fb9b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (let i = 0; i < 100 && !editor.editor && this.isConnected; i++) { | ||
| await new Promise((resolve) => setTimeout(resolve, 50)); | ||
| } |
There was a problem hiding this comment.
On a slow connection or device where the editor's dynamic imports and draft initialization take more than five seconds, this polling loop exits before editor.editor exists. Nothing subsequently initializes baseline, so dirty remains false and the Save button cannot be enabled even after the user edits the content. Use an editor-ready signal or otherwise initialize the baseline whenever editor creation eventually completes.
Useful? React with 👍 / 👎.
| return html` | ||
| <comment-editor | ||
| ${ref(this.editorRef)} | ||
| .initialContent=${this.editorContent} |
There was a problem hiding this comment.
When an existing comment contains supported display HTML outside the editor schema, passing it into this editor normalizes or drops that markup before any user action; for example, cleanHtml retains headings while comment-editor.ts explicitly configures heading: false. Saving an unrelated text change therefore silently converts or removes the original structure. Either add extensions for the HTML accepted by the renderer or prevent editing without preserving unsupported nodes.
Useful? React with 👍 / 👎.
1 participant
Port the comment content editing capability from Halo Console (halo-dev/halo#10302) to the comment widget, so users with comment management permission can edit comment and reply bodies directly on the frontend.
system:comments:managepermission and hidden for deleted targetsPUT /apis/api.console.halo.run/v1alpha1/{comments|replies}/{name}/contentendpoints withraw,content, and the loadedversion, preserving moderation state and authorshipcontent-visibility: autopaint containment on the item content container while editingRequires a Halo version that includes halo-dev/halo#10302. On older versions, saving fails with an inline error and the draft is kept; nothing else in the widget is affected.
Validation:
pnpm build,tsc --noEmit,biome check, andvitest run(122 tests) all pass