fix(bit-timing): support extended hardware limits - #2094
Open
timothyanderson096-ocdealcheck wants to merge 2 commits into
Open
fix(bit-timing): support extended hardware limits#2094timothyanderson096-ocdealcheck wants to merge 2 commits into
timothyanderson096-ocdealcheck wants to merge 2 commits into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8865a0a935
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
BitTiming.iterate_from_sample_point()andBitTiming.from_sample_point()to use controller-specifictseg1_max,tseg2_max, andbrp_maxlimits.The regression case uses a 160 MHz CAN clock at 250 kbit/s and an 87.5% sample point. Before this change it raises
ValueError: No suitable bit timings found.; afterwards it selects the validbrp=40,tseg1=13,tseg2=2timing. Abrp_max=39boundary check confirms the search remains bounded.Related Issues / Pull Requests
BitTiming.from_sample_pointrejects valid timing solutions due to hardcoded register limits #2083Type of Change
Checklist
Testing
ruff check can examples docblack --check can/bit_timing.py test/test_bit_timing.pymypy --python-version 3.10 .Additional Notes
The skipped tests require unavailable hardware or platform-specific drivers.