fix(devtools): toggle stuck ON — persist enabled state bidirectionally

[jeonghun-jj-lee]

Problem

The developer tools release ↔ dev toggle in Settings was non-functional. Clicking it did nothing visible — the switch stayed ON permanently.

Root Cause

A controlled-component + state-persistence mismatch:

1. defaultSettings.developer.enabled was true — the toggle always showed ON
2. The OFF path deliberately did NOT persist false to the SolidJS store (stale comment: "marketplace build doesn't render this section")
3. Kobalte's controlled <Switch checked={enabled()}/> always reflected the stale true
4. Every user click fired onChange(false) but since the signal never updated, the visual snapped back to ON
5. The ON path (setEnabled(true), which autofills paths and triggers rebuild) was unreachable from the UI

Fix

• Default developer.enabled to false (fresh installs show OFF, toggle can be turned ON)
• Persist both true and false via settings.developer.setEnabled(value) unconditionally — the controlled component now reflects reality

The toggle is now bidirectional: ON triggers a full rebuild, OFF restores the marketplace dist and reloads.

Companion PR

The same fix applied to the opencode local/amicode branch (where the app source lives for the running dev build).

Summary by CodeRabbit

• New Features
  • Developer Tools are now disabled by default.
  • Disabling Developer Tools reliably restores the marketplace extension and reloads the application.
• Bug Fixes
  • Developer Tools settings now persist correctly when disabled.
  • Onboarding no longer appears immediately after restoring the marketplace extension.
• Tests
  • Added coverage for one-time restoration handling and onboarding behavior.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f8dd2fe5-cd22-4801-8ce4-5375c3e0e1a6

📥 Commits

Reviewing files that changed from the base of the PR and between 324a5ec and 9cd188a.

📒 Files selected for processing (7)

• packages/app-bundle/overlay/packages/app/src/components/settings-v2/developer-tools-controller.ts
• packages/app-bundle/overlay/packages/app/src/context/settings.tsx
• packages/extension/.gitignore
• packages/extension/src/chat_bridge.ts
• packages/extension/src/opencode_config.ts
• packages/extension/src/substrate/vault_store.ts
• packages/extension/test/onboarding_routing.test.ts

---

📝 Walkthrough

Walkthrough

Developer Tools now persists disabled state, restores the marketplace extension through uninstall and install commands, and records a one-time restore marker. Extension activation consumes the marker to bypass onboarding. Developer mode is disabled by default.

Changes

Developer Tools restore flow

Layer / File(s)	Summary
Persist toggle state and restore marketplace packages/app-bundle/overlay/packages/app/src/components/settings-v2/developer-tools-controller.ts, packages/app-bundle/overlay/packages/app/src/context/settings.tsx, packages/extension/src/chat_bridge.ts, packages/extension/.gitignore	The controller persists both toggle states. Developer mode defaults to disabled. The extension disable flow writes a restore marker, reinstalls the marketplace extension, and reloads the window.
Consume restore marker during onboarding packages/extension/src/substrate/vault_store.ts, packages/extension/src/opencode_config.ts, packages/extension/test/onboarding_routing.test.ts	The vault store supports one-time marker consumption. Onboarding skips its flow when the marker is consumed. Tests cover missing markers, deletion, and onboarding state preservation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant DeveloperToolsController
  participant settings_developer
  participant chat_bridge
  participant VaultStore
  participant VSCodeCLI
  participant Window
  DeveloperToolsController->>settings_developer: persist disabled value
  DeveloperToolsController->>chat_bridge: send disabled update
  chat_bridge->>VaultStore: write restore marker
  chat_bridge->>VSCodeCLI: uninstall and install marketplace extension
  VSCodeCLI-->>chat_bridge: complete reinstall callback
  chat_bridge->>Window: reload window

Loading

sequenceDiagram
  participant ExtensionActivation
  participant VaultStore
  participant OnboardingRouting
  ExtensionActivation->>VaultStore: consume restore marker
  VaultStore-->>ExtensionActivation: return marker presence
  ExtensionActivation->>OnboardingRouting: evaluate onboarding eligibility
  OnboardingRouting-->>ExtensionActivation: skip onboarding when marker exists

Loading

Suggested reviewers: aarontrowbridge

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/devtools-toggle-stuck-on

---

_{Comment @coderabbitai help to get the list of available commands.}