deliberate: amendments are first-class specs - #511
Merged
Conversation
…et as originals Two same-day incidents (2026-08-22): post-conversation amendment drafts contradicted their parent specs' frozen contracts (6 and 9 blockings, caught only by post-hoc review). The skill now mandates the full review loop for amendments and the line-by-line re-read before drafting. Closes #510.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe deliberate skill now treats amendments to approved specs as first-class specs. It requires parent-spec and sibling-amendment consistency checks, the same three-lens review process and round budget, and separate review records. ChangesApproved spec amendment guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510.
Adds the amendment-review clause to the deliberate skill: amendments to approved specs get the same three-lens adversarial review and round budget as originals, with a line-by-line re-read of the parent spec (invariants, D-decisions, Measurement Protocol, prior amendments) before drafting. Evidence: the two same-day amendment incidents on the vault-distillation spec (see its review notes) — both cheap-talk drafts, both caught only by post-hoc review.
Summary by CodeRabbit