Upload release assets with the GitHub CLI - #46
Merged
Conversation
Release assets are now attached by gh release upload in the build job, replacing the third-party action that ran in the publish job. They are attached before publishing to PyPI, so a failure there still leaves a complete release, and --clobber makes the step safe to re-run.
bruno-f-cruz
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow no longer depends on a third-party action.
gh release uploadreplacessoftprops/action-gh-release.The step also moves from the publish job to the build job, so the distributions are attached to the release before the PyPI upload runs. A failure in trusted publishing then still leaves a complete release rather than an empty one, and
--clobbermakes the step idempotent, so re-running the job does not fail on assets already attached.contents: writemoves with the step, leaving the publish job with only theid-token: writethat trusted publishing needs.