Repository navigation
test(ebs): fix weekly acceptance test failures - #716
Conversation
4fc4fb2 to
61c3b17
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Two unconditional skips remove important reboot and reconnection acceptance coverage without bounded tracking.
1 open finding
What changed in this PR
Updates EBS acceptance fixtures to improve weekly test reliability.
Changes:
- Dynamically selects current Ubuntu 22.04 AMIs.
- Updates instance types and Ubuntu provisioning commands.
- Disables two failing reboot acceptance tests.
| File | Description |
|---|---|
builder/ebs/test-fixtures/unlimited-credits/burstable_spot_instances.pkr.hcl |
Modernizes spot-instance fixture. |
builder/ebs/test-fixtures/unlimited-credits/burstable_instances.pkr.hcl |
Modernizes on-demand fixture. |
builder/ebs/builder_acc_test.go |
Updates SSH setup and instance types; skips reboot tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Looks good! I think we should be good once the remaining 2 are fixed. |
| } | ||
|
|
||
| // A reboot that completes between two polls may never show as disconnected; carry on in that case. | ||
| _ = waitFor(ssmtypes.ConnectionStatusNotConnected, ssmAgentDownTimeout) |
There was a problem hiding this comment.
the helper only acts after the build logs rebooting VM, and it is test-only code. The gap needs a GetConnectionStatus failure in the ~10s between the reboot being issued and the SSM agent going down. If that happens, the worst case is that this test run hangs and fails as before; there is no impact on the plugin or users.
148677b to
26b10c0
Compare
…he reboot test cases
26b10c0 to
58b3d26
Compare
This PR fixes three main issues:
Dead AMI — The hardcoded source AMI we were using got deregistered. Instead of pinning to a specific AMI ID, we now dynamically look up the latest
hc-security-base-ubuntu-2204image. This way tests stay green even when AMIs change.Instance type capacity — We were using t2.micro instances, which kept hitting capacity issues in certain AZs. Bumping to t3.micro (and t3.small where needed) gives us more reliable test runs.
Ubuntu compatibility — We switched the base images to Ubuntu, so the provisioning scripts needed updates:
dnftoapt-get[[ ]]to POSIX[ ]for better portabilityTestAccBuilder_EbsSSMRebootProvisionerTestAccBuilder_PrivateKeyFileWithReboot