Skip to content

error-stack UI tests fail under nightly-2022-07-20 #897

New issue
New issue
Closed
#904
Closed
error-stack UI tests fail under nightly-2022-07-20#897
#904
Assignees
TimDiekmann
Labels
area/libs > error-stackAffects the `error-stack` crate (library)

Description

@indietyp
indietyp
opened on Aug 6, 2022

nightly-2022-07-20 (rust 1.64 stable) introduced rust-lang/rust#98320, which means that the UI and acceptance tests for the macro errors fail on toolchains newer than that.

hash/packages/libs/error-stack/tests/ui/macro_invalid_args.stderr

Line 49 in 45598cd

= note: this error originates in the macro `$crate::report` (in Nightly builds, run with -Z macro-backtrace for more info)

This is changed to:

= note: this error originates in the macro `$crate::report` which comes from the expansion of the macro `bail` (in Nightly builds, run with -Z macro-backtrace for more info)

hash/packages/libs/error-stack/tests/ui/macro_invalid_args.stderr

Line 62 in 45598cd

= note: this error originates in the macro `$crate::report` (in Nightly builds, run with -Z macro-backtrace for more info)

This is changed to:

= note: this error originates in the macro `$crate::report` which comes from the expansion of the macro `ensure` (in Nightly builds, run with -Z macro-backtrace for more info)

The which comes from the expansion of the macro `...` part is new.

Activity

  1. indietyp commented on Aug 6, 2022

    @indietyp
    indietyp
    on Aug 6, 2022
    MemberAuthor

    To fix this, we could either

    1. update the tests and CI (single PR) - because we already only compiletest on nightly
    2. use rustversion to conditionally emit additional code on toolchains that are newer than 2022-07-20

    (from the logs of #892 it also seems like the code to fetch the nightly toolchain version seems broken)

    @TimDiekmann what do you think?

  2. vilkinsons
    assigned
    TimDiekmann
    on Aug 7, 2022
  3. vilkinsons
    added
    area/libs > error-stackAffects the `error-stack` crate (library)
    on Aug 7, 2022
  4. vilkinsons
    changed the title [-]error-stack ui tests fail under nightly-2022-07-20[/-] [+]`error-stack` UI tests fail under `nightly-2022-07-20`[/+] on Aug 7, 2022

  5. TimDiekmann commented on Aug 7, 2022

    @TimDiekmann
    TimDiekmann
    on Aug 7, 2022
    Member

    Thanks for filing this!

    I think the easiest way is to simply bump the nightly version used in CI, this will also fix #898. I will do this tomorrow.

    (from the logs of #892 it also seems like the code to fetch the nightly toolchain version seems broken)

    Currently, it uses the first rust-toolchain.toml file it finds in the repository to determine the nightly version, this is why we currently try to keep the nightly versions on par between the different projects (package/engine, packages/libs/error-stack and packages/graph(on dev/graph) ). Probably there is a better way to this, but I haven't investigated this yet.

  6. indietyp commented on Aug 7, 2022

    @indietyp
    indietyp
    on Aug 7, 2022
    MemberAuthor

    What I specifically mean is the error:

    Run nightly=$(cat $(find . -name rust-toolchain.toml) | grep channel | cut -d\" -f2)
parse error: Invalid literal at line 2, column 0
use toolchains:

    Which turns up in the CI.

  7. TimDiekmann
    closed this as completedin #904on Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area/libs > error-stackAffects the `error-stack` crate (library)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions