Skip to content

Add GHCJS deprecation notice - #12429

Merged
mergify[bot] merged 1 commit into
haskell:3.18from
cabalism:doc/deprecate-ghcjs
Oct 12, 2026
Merged

Add GHCJS deprecation notice#12429
mergify[bot] merged 1 commit into
haskell:3.18from
cabalism:doc/deprecate-ghcjs

Conversation

@philderbeast

@philderbeast philderbeast commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

After asking around and posting on discourse we received no objections. The ghcjs removal pull request is ready and approved. This is the deprecation notice.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast
philderbeast requested a review from ffaf1 October 9, 2026 11:47
@philderbeast

philderbeast commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator Author

With these branch release note changes, do I wait for a second review and add "merge me" at the normal pace or do I need to expedite it before the 3.18.2.0 release is announced?

@philderbeast
philderbeast requested a review from Mikolaj October 9, 2026 14:45
@ffaf1

ffaf1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

do I wait for a second review and add "merge me" at the normal pace or do I need to expedite it before the 3.18.2.0 release is announced?

Expedite the backport, since this that (master) is where changelog files point to.

@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Oct 12, 2026
@mergify mergify Bot added the queued label Oct 12, 2026
@mergify

mergify Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-10-12 12:47 UTC · Rule: default · triggered by rule Put release branch pull requests in the rebase+merge queue
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-10-12 12:57 UTC · at 293a2d7bb6d76b0581460f436a487e63bead23cb · merge

This pull request spent 10 minutes 22 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify
mergify Bot merged commit 293a2d7 into haskell:3.18 Oct 12, 2026
57 checks passed
@mergify mergify Bot removed the queued label Oct 12, 2026
@philderbeast

philderbeast commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@mergify backport

@mergify

mergify Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

backport

❌ No backport have been created

Details

No destination branches found

@philderbeast

philderbeast commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@mergify backport master

@mergify

mergify Bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

backport master

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request Oct 12, 2026
Merged
1 of 2 tasks
@mergify mergify Bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Oct 13, 2026
mergify Bot added a commit that referenced this pull request Oct 13, 2026
@mergify
Merge pull request #12453 from haskell/mergify/bp/master/pr-12429
bb3193f 
Backport #12429: Add GHCJS deprecation notice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zlonast zlonast zlonast approved these changes
@ffaf1 ffaf1 ffaf1 approved these changes
@Mikolaj Mikolaj Awaiting requested review from Mikolaj

Assignees

No one assigned

Labels

attention: needs-backport master merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philderbeast @ffaf1 @zlonast