Skip to content

SetupWrapper: make impossible cases unrepresentable #12434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreabedini wants to merge 5 commits into
base: master
Choose a base branch
from
+214 −203
Open

SetupWrapper: make impossible cases unrepresentable #12434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c263bf
SetupWrapper: make impossible cases unrepresentable
claude Oct 9, 2026
822f3c1
SetupWrapper: fold InLibraryRun into InLibraryArgs
andreabedini Oct 13, 2026
82afd65
SetupWrapper: name the generated scripts *SetupScript
andreabedini Oct 13, 2026
b713a30
SetupWrapper: say Cabal 3.14, not 3.13
andreabedini Oct 13, 2026
2515550
SetupWrapper: replace InLibraryLBI with Maybe LocalBuildInfo
andreabedini Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cabal-install/src/Distribution/Client/ProjectBuilding/UnpackedPackage.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ import Web.Browser (openBrowser)
-- the phases will be carried out differently. For example, when installing,
-- the test, benchmark, and repl phase are ignored.
data PackageBuildingPhase r where
PBConfigurePhase :: {runConfigure :: IO InLibraryLBI} -> PackageBuildingPhase InLibraryLBI
PBConfigurePhase :: {runConfigure :: IO (Maybe Cabal.LocalBuildInfo)} -> PackageBuildingPhase (Maybe Cabal.LocalBuildInfo)
PBBuildPhase :: {runBuild :: IO [MonitorFilePath]} -> PackageBuildingPhase ()
PBHaddockPhase :: {runHaddock :: IO [MonitorFilePath]} -> PackageBuildingPhase ()
PBReplPhase :: {runRepl :: IO [MonitorFilePath]} -> PackageBuildingPhase ()
Expand Down Expand Up @@ -489,7 +489,7 @@ buildAndRegisterUnpackedPackage
scriptOptions{isInteractive = True}
(Just (elabPkgDescription pkg))

generateInstalledPackageInfo :: InLibraryLBI -> IO InstalledPackageInfo
generateInstalledPackageInfo :: Maybe Cabal.LocalBuildInfo -> IO InstalledPackageInfo
generateInstalledPackageInfo mbLBI =
withTempInstalledPackageInfoFile
verbosity
Expand Down Expand Up @@ -698,7 +698,7 @@ buildInplaceUnpackedPackage
(monitors ++ monitors' ++ dep_monitors)
buildResult

whenReconfigure :: IO InLibraryLBI -> IO InLibraryLBI
whenReconfigure :: IO (Maybe Cabal.LocalBuildInfo) -> IO (Maybe Cabal.LocalBuildInfo)
whenReconfigure configure_action =
case buildStatus of
BuildStatusConfigure _ -> configure_action
Expand All @@ -724,7 +724,7 @@ buildInplaceUnpackedPackage
builtinPrograms
(Cabal.withPrograms lbi_wo_programs)
}
return $ InLibraryLBI lbi
return $ Just lbi

whenRebuild, whenReRegister :: IO () -> IO ()
whenRebuild action
Expand Down
Loading
Loading