Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After messing with the printing of integers in #716, I noticed that the parsing is naive and quadratic. This implements a quasi-linear algorithm by using the same divide-and-conquer technique as for printing.
For the lazy version, I make use of
splitAtWord, so I moved it and export it from an internal module. While I was at it, I removed the awkward import of a custom strict pair, instead directly ensuring that the result doesn't produce thunks.Added some very basic benchmarks for comparison with
read/readHexon strings, mainly as a sanity check, but we can observe that we are quite faster even with a lazy text made of single-character chunks.