Repository navigation
chore: version 0.1.0-rc.1 - #87
Merged
Merged
Conversation
One version for every crate in the workspace, Cargo.lock to match, and the Android versionName and versionCode. The path dependencies between our crates no longer repeat the version. The README status says what works now.
They are never published, so their path dependencies need no version and cargo-deny does not flag them as wildcards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86
What: the workspace version,
Cargo.lockand the AndroidversionNameare0.1.0-rc.1, andversionCodeis 10001. The README status says what works now (Android and Linux over USB and WiFi, proxy and TUN mode, the opt-in kill switch, the desktop app, .deb and AppImage) and what is coming (Windows, iPhone, macOS).Why:
release.ymlrefuses a tag that does not match the Cargo and Android versions, sov0.1.0-rc.1needs these. The path dependencies between our crates repeatedversion = "0.0.0", which a bump would have broken; they are path-only now, so a bump is one line inCargo.toml.versionCodefollows MAJOR1000000 + MINOR10000 + PATCH*100 + R (R the rc number, 99 for the release), written up indocs/releasing.md, so it only goes up.How I tested it:
cargo metadata --lockedandcargo check --locked --workspacepass. I ran the version check fromrelease.ymlby hand against this tree: the tag regex matchesv0.1.0-rc.1and Cargo and Android both say0.1.0-rc.1. No tag is pushed.