Repository navigation
build: install uniffi-bindgen outside the workspace - #93
Merged
Merged
Conversation
The bindgen feature pulled uniffi_bindgen and its dependencies into Cargo.lock, among them basic-toml, which is flagged unmaintained. build-rust.sh now installs the generator with cargo install --locked into target/, at the version of the uniffi crate in Cargo.lock. The generated Kotlin is byte for byte the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92
kite-ffihad an optionalbindgenfeature and auniffi-bindgenbin, which pulleduniffi_bindgenand 14 more crates intoCargo.lock. One of them, basic-toml, has a RUSTSEC unmaintained advisory that Scorecard counts. They are only needed to generate the Kotlin bindings, never at runtime.apps/android/build-rust.shnow runscargo install uniffi --version =X --locked --features cli --bin uniffi-bindgen --root target/uniffi-bindgen-Xon first use, where X is theuniffiversion read fromCargo.lock, so the generator always matches the library. The CI, release and screenshot workflows call the script, so they need no change.Cargo.lockloses 193 lines and gains none.The other 7 advisories stay. bincode is not from bindgen:
typed-index-collectionsin slint's compiler lists it, so it stays in the lock while slint does. pin-utils, ttf-parser and the zbus crates come from slint 1.18.1 and ksni 0.3.7 (both latest), daemonize from tun2proxy (#63). Expect Vulnerabilities to go from 8 findings to 7.Testing: generated the Kotlin bindings from the same debug
kite_ffilibrary with the oldcargo run --features bindgenand with the installed 0.32.2 binary and compared them withdiff -r: identical.cargo build --locked -p kite-ffiandcargo deny checkpass. The Android CI job runs the new script end to end.No new dependency in the workspace; the generator is the same crate and version as before.