fix(lint): flag hidden-style opacity guards - #3694
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Hidden-style opacity guard lint rule with proper CSS selector parsing. Correctly exempts sub-composition host scoping and non-opacity declarations. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lintandchecknow reject broad CSS guards that turn renderer-ownedvisibility: hiddenintoopacity: 0. This prevents successfully extracted video frames from becoming transparent while keeping guards explicitly scoped to sub-composition hosts valid.Why
The renderer hides each native video before it copies the video's computed opacity to the visible replacement image. A broad
[style*="visibility: hidden"]opacity rule observes that runtime mutation, sets the native opacity to zero, and causes the copied frame to remain transparent for every rendered frame.How
data-composition-srcordata-composition-file.Test plan