fix(lint): flag repeated fromTo state leaks - #3699
Open
miguel-heygen wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lint now warns when repeated future
fromTocalls can leak the last authored start state into earlier frames. ExplicitimmediateRender: falseand an earlier timeline baseline remain clean.Why
GSAP applies default
fromTostart values while the timeline is built, before the tween's scheduled position. When several calls target the same element, the last authored start state can become visible before the first tween, while existing lint reports no cause.A standalone
gsap.setis not accepted as proof of safety. An earlier global set can be overwritten by laterfromToconstruction, and a set for unrelated properties does not establish the affected state. The warning therefore clears only for explicit opt-out or an earliertl.setbaseline that participates in deterministic timeline seeking.How
immediateRenderas explicit true, explicit false, or the GSAP method default.fromTowriters by stable selector.immediateRender: falseon the repeated writers.Test plan