fix(cli): recognize textual motion in sweep checks - #3707
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes checknow recognizes fixed-geometry text, generated content, CSS counters, and form-control state as real motion instead of failing them withsweep_static. A genuinely frozen composition still fails the guard.Why
The sweep guard compared box geometry, opacity, variable-font axes, and media pixels across seek samples. A fixed-width countdown could visibly change from
10to09while every recorded field stayed identical, socheckconcluded that the timeline never advanced. Exact elapsed-time values passed only when their glyph widths happened to alter geometry.Leading-zero coercion in
data-txtremains unchanged because GSAP AttrPlugin owns that behavior. This PR fixes only HyperFrames' liveness proof; authoring guidance or a lint hint for numeric attribute strings remains separate.How
::before/::aftercontent, and live form values into the existing per-sample fingerprint.sweep_staticdecision and severity unchanged when all visible-state fingerprints remain equal.Test plan
attr()content, pseudo-content, zero-box counter owners, text inputs, checkboxes, and multi-select state change the fingerprint.studioServer.tsNonSharedBuffertyping and missingajv/dist/2020.js.