fix(lint): recognize supported timeline registration forms - #3760
Open
Bortlesboat wants to merge 1 commit into
Open
fix(lint): recognize supported timeline registration forms#3760Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stop warning that a composition has no timeline when it registers one with
window.__timelines.c1 = tlorwindow.__timelines = { c1: tl }. Commented registrations no longer suppress the warning.Why
Those forms are already recognized by the core lint rule. The contradictory warning suggests adding
data-no-timelineto a working composition.How
Reuse the existing registration patterns after stripping comments. Keep the conservative bracket check for computed keys and logical assignments.
Test plan
bun run --filter @hyperframes/lint test -- --reporter=dot --maxWorkers=4.Oxlint, oxfmt, the lint package typecheck, and both package builds pass. Earlier runs hit the existing
stripJsStringLiterals scalingtiming assertion; it also failed on unchangede5d89f7. The final full run passed.Post-Deploy Monitoring & Validation
No additional operational monitoring required; this changes static lint diagnostics only.