fix(lint): flag static composition hosts without opt-out - #3763
Open
QiuLsG wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
missing_data_no_timelineto report each bare nesteddata-composition-idhost without a matching timeline, explicit opt-out, or sub-composition source.Why
Static nested hosts also participate in renderer readiness. Without a timeline or
data-no-timeline, rendering waits for the player-ready timeout, but the existing lint rule only diagnosed the root composition.How
The existing rule now compares every authored composition id with statically extractable timeline registry keys and emits one actionable warning per unresolved host. Real sub-composition mounts, inert templates, explicit opt-outs, and registrations that cannot be safely analyzed remain exempt.
Test plan
@hyperframes/lint: 612 passed)bun run buildbun run lintFull
bun run testwas also attempted on Windows. It reports unrelated platform/concurrency-sensitive failures involving symlink permissions, path separators, and timeouts; the lint package passes.Closes #3743